Review Request: Update KDateTime to use qint64 for days/secs/msecs

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107062/#review20961
-----------------------------------------------------------

Ship it!


Looks good.

- David Faure


On Oct. 26, 2012, 1:29 p.m., Jon Severinsson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107062/
> -----------------------------------------------------------
> 
> (Updated Oct. 26, 2012, 1:29 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Update KDateTime to use qint64 for days/secs/msecs
> 
> This is in order to match the QDateTime changes in Qt5.
> Also simplify some implementations by using the QDateTime equivalent.
> 
> In order to avoid having to change several hundred lines of code in the test, this
> patch depends on "Allow QtTest's QCOMPARE to work with mixed (u)int and q(u)int64".
> 
> 
> Diffs
> -----
> 
>   kdecore/date/kdatetime.h 6b6b893b7a24a1bfd9fc549400ced6e3a6acf626 
>   kdecore/date/kdatetime.cpp 0632cd3e5d9d305def409f65a2fdd81205018c51 
> 
> Diff: http://git.reviewboard.kde.org/r/107062/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jon Severinsson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20121026/fb4c5476/attachment.html>