Review Request: Remove QFSFileEngine useage from Phonon five.
David Faure
faure at kde.org
Sun Oct 21 10:46:43 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106974/#review20619
-----------------------------------------------------------
Urgh, too much detailed magic.
Either the input string is always a local path, and use fromLocalFile. Or it's always a URL, and use QUrl(QString). Or it could be either one, and then QUrl::fromUserInput(QString) is what you're looking for.
- David Faure
On Oct. 21, 2012, 9:59 a.m., Jon Severinsson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106974/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2012, 9:59 a.m.)
>
>
> Review request for KDE Frameworks and Phonon.
>
>
> Description
> -------
>
> QFSFileEngine has been removed from Qt5, so rip it out of phonon/mediasource.cpp. Any pointers to a propper fix would be welcome.
>
>
> Diffs
> -----
>
> phonon/mediasource.cpp 9e35094
>
> Diff: http://git.reviewboard.kde.org/r/106974/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jon Severinsson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20121021/8d2694a9/attachment-0001.html>
More information about the Kde-frameworks-devel
mailing list