Review Request: Remove QFSFileEngine useage from Phonon five.

David Faure faure at kde.org
Sat Oct 20 20:23:12 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106974/#review20604
-----------------------------------------------------------


kcoreaddons has KFileSystemType, to distinguish local from NFS/SMB (which I guess this is what this was about).
Maybe it could go into Qt.... I guess for now this is ok (unless we want to use kcoreaddons in phonon, but I doubt that)

- David Faure


On Oct. 20, 2012, 7:49 p.m., Jon Severinsson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106974/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2012, 7:49 p.m.)
> 
> 
> Review request for KDE Frameworks and Phonon.
> 
> 
> Description
> -------
> 
> QFSFileEngine has been removed from Qt5, so rip it out of phonon/mediasource.cpp. Any pointers to a propper fix would be welcome.
> 
> 
> Diffs
> -----
> 
>   phonon/mediasource.cpp 9e35094 
> 
> Diff: http://git.reviewboard.kde.org/r/106974/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jon Severinsson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20121020/e9793f7e/attachment.html>


More information about the Kde-frameworks-devel mailing list