[PATCH] Remove KDateTime limitation of 4712 BCE [v2].

David Faure faure at kde.org
Tue Oct 9 15:28:06 UTC 2012


On Monday 08 October 2012 16:44:17 Jon Severinsson wrote:
> OK, did one better and made sure the date was a negative jd even when
> interpreted as a Proleptic Gregorian date (as Qt5 does) rather than as
> a Proleptic Julian date (as Qt4 does), and hid it in an Qt version
> check (as when interpreted as a Proleptic Julian date it is well below
> jd 0, and Qt4 uses an unsigned 32-bit integer for jd).

Thanks!
 
> Also updated some more documentation to relflect the improved QDate
> in Qt5 (eg is a Proleptic Gregorian with improved range).

Hmm, did you remove too much documentation?

This, for instance, still applies, doesn't it?

  *
- * @section compatibility QDateTime Considerations
- *
- * KDateTime's interface is designed to be as compatible as possible with that
- * of QDateTime, but with adjustments to cater for time zone handling. Because
- * QDateTime lacks virtual methods, KDateTime is not inherited from QDateTime,
- * but instead is implemented using a private QDateTime object.

Only the stuff about the date range restriction should be removed.

-- 
David Faure, faure at kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5



More information about the Kde-frameworks-devel mailing list