[PATCH] Remove KDateTime limitation of 4712 BCE.

[David Faure]

On Sunday 07 October 2012 22:30:28 Jon Severinsson wrote:
> This fixes test #12: kdecore-kdatetimetest when building on Qt5.

Thank you! Much appreciated.

> I choose to
> just rip it out rather than to preserve behaviour for Qt4, as I figgured we
> could live with a bad return value from outOfRange() until we drop Qt4
> support from the frameworks branch.

Sounds good. If this breaks the test with Qt4, feel free to add some #ifdefs 
on the Qt version, in order to skip the broken tests with Qt4.


Patch looks good to me, but John Layt should approve it, ideally.

Just one thing seemed odd:
-    dt = KDateTime::fromString(QLatin1String("-471412311430:01.3+0500"), 
QLatin1String("%Y%m%d%H%M%:S%:s%z"));
-    QVERIFY(!dt.isValid());    // too early
-    QVERIFY(dt.outOfRange());

Why remove the test altogether, rather than keeping it and adjusting the 
expected result?

-- 
David Faure, faure at kde.org, http://www.davidfaure.fr
Working on KDE, in particular KDE Frameworks 5