[PATCH 1/3] Drop KDE_NO_PHONON, Phonon works on Qt5 now.

Stephen Kelly steveire at gmail.com
Wed Nov 21 12:54:17 UTC 2012


David Faure wrote:

> Hi Jon,
> 
> What's the status on phonon-for-Qt5? If all changes got merged in, maybe
> this patch can be applied to kdelibs-frameworks?

I think KDE_NO_PHONON still has value anyway. 

It makes it easier to do things in the frameworks branch because you don't 
have to build all 'kdelibs dependencies' first. That makes it easier to do 
eg buildsystem stuff, splitting kdeui etc.

If you remove KDE_NO_PHONON, please make it possible to build the rest of 
the frameworks branch without requiring phonon. Eg using 

 if(PHONON_FOUND)
    add_subdirectory(foo)
 endif()

That would be actual progress toward what we want to do anyway.

Thanks,

Steve.




More information about the Kde-frameworks-devel mailing list