KArchive for Qt4

[Stephen Kelly]

David Faure wrote:

>> Also, if you don't use the feature_summary() function from
>> FeatureSummary.cmake, then you don't have to use
>> set_package_properties().
> 
> Oops, oversight.
> 

I just looked through the zip. Do you have an updated version with some 
issues fixed/removed?

>> You use the EXPORT argument in install(TARGETS ...), but don't install
>> the generated exports-file nor a KArchiveConfig.cmake file.
>>
>> Generating a good Config.cmake file is not trivial, as can be seen on the
>> lengthy threads about this on kde-frameworks.

For KDE, that might be true, but in general for trivial libraries like 
karchive-qt4 I think it is trivial.

>> This is also IMO the most
>> significant issue in the buildsystem in the frameworks branch which is
>> still far away from its final form.
> 
> I'm fine with not providing this. The goal of this early release is to
> ship the code, people can then integrate it into their (commercial or
> opensource) apps. I'm not sure if karchive-qt4 should be a separate
> package installed by the next version of all linux distros. This is why I
> started this thread, in fact -- to get feedback on this question.
> But if our buildsystem isn't ready for that, I'm pretty sure that's "good
> enough" for the people who requested such a package. They will either port
> it to qmake, or they already use cmake anyway and can merge that into
> their tree, or they can write a quick FindKArchiveQt4.cmake. OK I agree
> none of this is ideal, but again -- if this part of KF5 isn't ready, then
> the proper fix is for later.
> 

I can help create a Config file if you update the zip archive.

Thanks,

Steve.