Review Request: When building Phonon five against Qt5, use qmake to detect Qt installation paths.

[Jon Severinsson]

fredagen den 2 november 2012 11:18:15 skrev  David Faure:
> On Wednesday 31 October 2012 21:57:55 Stephen Kelly wrote:
> > David Faure wrote:
> > > CMakeLists.txt
> > > <http://git.reviewboard.kde.org/r/106972/#comment16584>
> > > 
> > > Steve? Something for you to add to the Qt5 cmake files?
> > 
> > I don't know. Should phonon really install phonon plugins into the paths
> > for *Qt* plugins and qml files?
> > 
> > Is that a leftover from when phonon was part of Qt?
> 
> Right. With the frameworks idea, better install into the prefix, using the
> directories I defined in ECM (KDEInstallDirs.cmake, QT_PLUGIN_INSTALL_DIR)
> 
> The user will have to set QT_PLUGIN_PATH if installing phonon into a
> different dir than Qt, but that's fine -- it will only have to be done
> once, for all of the frameworks installed into the same prefix.
> 
> So let's do that, rather than use qmake to detect where Qt got installed
> (which could be in non-writable /usr...)

OK, I will rework this into my "Port Phonon five build system to ECM and 
Qt5Transitional.cmake" patch.

Regards
Jonno
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20121103/5a8e5631/attachment.sig>