Qt5 cmake stuff

[David Faure]

On Monday 14 May 2012 23:32:10 Alexander Neundorf wrote:
> On Monday 14 May 2012, David Faure wrote:
> > On Monday 14 May 2012 23:22:09 Alexander Neundorf wrote:
> > > On Monday 14 May 2012, Alexander Neundorf wrote:
> > > ...
> > > 
> > > > For now, you can change the code e.g. to
> > > > if (NOT TARGET Qt5::Core)
> > > > 
> > > >   message(STATUS "DF: Qt5CoreConfig.cmake add_library(Qt5::Core)")
> > > >   add_library(Qt5::Core SHARED IMPORTED)
> > > > 
> > > > endif()
> > > > 
> > > > OR
> > > > 
> > > > if (NOT _qt5CoreTargetExists)
> > > > 
> > > >   set(_Qt5Core_target TRUE)
> > > 
> > > Should be:
> > > set(_qt5CoreTargetExists TRUE)
> > 
> > Yes but this solution is basically the one that this commit moved away
> > from:
> Yes, I know. It should have been good, I really think this is a regression
> in cmake :-/
> And of course actual testing instead of glancing over it would have helped
> :-/

I didn't mean to blame anyone. I meant that surely "setting a variable" wasn't 
an acceptable solution, since this commit moved away from that solution for a 
reason (something such as calling find_package in a function scope).

So the if (NOT TARGET Qt5::Core) solution seems much better to me
than the if (NOT _qt5CoreTargetExists) solution, which reintroduces the 
original issue.

-- 
David Faure, faure at kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. KDE Frameworks 5