Patch: Use QLatin1String instead of KGlobal::staticQString

David Faure faure at kde.org
Fri Jun 15 07:58:50 UTC 2012


On Thursday 14 June 2012 22:13:28 Jignesh Kakadiya wrote:
> Updated patch.

This will call db.mimeTypeForName() every time, in the unlikely where the 
mimetype is missing, so my suggestion was
  defaultFolderIcon = "unknown";
rather than
  return DesktopIcon( "unknown", _size, _state );
(just under the kWarning)

Looks good otherwise, please adjust and commit.

-- 
David Faure, faure at kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. KDE Frameworks 5



More information about the Kde-frameworks-devel mailing list