Simplifying QtGui includes?

David Faure faure at kde.org
Wed Feb 1 23:14:58 UTC 2012


On Wednesday 01 February 2012 18:02:17 Stephen Kelly wrote:
> Hi,
> 
> One of the big changes in Qt5 is the split of parts of QtGui into QtWidgets.
> 
> That means for example that includes such as
> 
> #include <QtGui/QDialog>
> 
> will no longer work. Includes with the module will have to look like:
> 
> #include <QtWidgets/QDialog>
> 
> However,
> 
> #include <QDialog>
> 
> works in both cases (Qt 4 and 5).
> 
> I would like to remove the 'QtGui/' en-masse from kdelibs. This will allow
> me and others to easy test porting to Qt5. As the QtModule directories are
> always part of our include_directories, I see no disadvantage.
> 
> Any objections?

Go for it. I never liked the explicit module names in includes, and now I have 
a pretty good argument against them: the above.

-- 
David Faure, faure at kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. KDE Frameworks 5



More information about the Kde-frameworks-devel mailing list