Review Request: Cleanup : Move all gesture facilities of KAction in KGestureMap

[Valentin Rusu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107973/
-----------------------------------------------------------

(Updated Dec. 30, 2012, 3:43 p.m.)


Review request for KDE Frameworks.


Changes
-------

This updated patch bring answers to Kevin's comments:
- KAction API was now left unchanged,
- KGestureMap API was modified to provide setGesture instead of addGesture methods.


Description
-------

This changeset removes all gesture facilities from KAction and define them in KGestureMap. Thanks for the feedback.


Diffs (updated)
-----

  kdeui/actions/kaction.h f45c94d 
  kdeui/actions/kaction.cpp b78d1d6 
  kdeui/actions/kaction_p.h f87272c 
  KDE5PORTING.html 86dfc1a 
  kdeui/dialogs/kshortcutseditor.cpp 5653984 
  kdeui/dialogs/kshortcutseditoritem.cpp e85a203 
  kdeui/shortcuts/kgesturemap.h 56b42b6 
  kdeui/shortcuts/kgesturemap.cpp 1350dbe 

Diff: http://git.reviewboard.kde.org/r/107973/diff/


Testing
-------

Code builds OK. KGestureMap is not actually used, though, as KGestureMap::eventFilter method return false right away.


Thanks,

Valentin Rusu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20121230/608f50e1/attachment.html>