Review Request: [PATCH 2/4] kcalendarsystem: Simplify the dayOfWeek() implementation.

[John Layt]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107688/#review23390
-----------------------------------------------------------


I personally don't see the need for this.  It's not making things faster, and restricting future options.  Changing the public api method from virtual to inline is not very future-proof.

On the whole virtual vs inline thing, I need to email the list with some history about this.

- John Layt


On Dec. 13, 2012, 7:41 a.m., Jon Severinsson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107688/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2012, 7:41 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Description
> -------
> 
> Day of week is the same for a given julian day number regardless of calendar system used.
> 
> 
> Diffs
> -----
> 
>   kdecore/date/kcalendarsystem.h efddd08 
>   kdecore/date/kcalendarsystem.cpp 1aed791 
>   kdecore/date/kcalendarsystemhebrew.cpp e3d1484 
>   kdecore/date/kcalendarsystemhebrew_p.h 75a6280 
>   kdecore/date/kcalendarsystemprivate_p.h d935ead 
>   kdecore/date/kcalendarsystemqdate.cpp f233d219 
>   kdecore/date/kcalendarsystemqdate_p.h 9363fff 
>   kdecore/tests/kcalendartest.h 505c137 
>   kdecore/tests/kcalendartest.cpp 85d790d 
> 
> Diff: http://git.reviewboard.kde.org/r/107688/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jon Severinsson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20121213/74686aa2/attachment.html>