KMessageBox and the notifications

[Valentin Rusu]

On Friday 07 December 2012 10:25:44 David Faure wrote:
> On Friday 07 December 2012 07:34:37 Kevin Ottens wrote:
> > Hello,
> > 
> > On Thursday 6 December 2012 23:32:21 Valentin Rusu wrote:
> > > KMessageBox (non-WId and non-queued methods) should go to kwidgets
> > > (actually in staging).
> > > 
> > > According to the current state of the code, it dependes on
> > > kdeui/notifications. This would require linking kwidgets to kdeui. But
> > > kdeui already links to kwidgets, leading to a circular reference between
> > > these libraries.
> > 
> > Could you refresh my memory, what is kdeui/notifications used for in
> > KMessageBox already?
> 
> Notification when popping up a messagebox (could lead to playing a sound, or
> anything else the user configures).
> 
> But this should be done from within QMessageBox itself, for full consistency
> between Qt apps, which in turn requires a notification framework in Qt,
> which in theory Sune is working on :-)
> 
> > If I remember the discussions at Akademy-fr correctly,
> > I think that this dependency isn't needed anymore and can be dropped, I
> > might be wrong though (that's why another check would be welcome).
> 
> I would suggest a #if 0 around the notification code for now, with a pragma
> message to remind us to take another look at this later. Don't let this
> block your KMessageBox work.

Ok, works for me!

-- 
Valentin Rusu (vrusu)
IRC: valir
KSecretsService (aka KSecretService, KWallet replacement)