Review Request: do translation correctly in solid

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105944/#review17151
-----------------------------------------------------------

Ship it!


Thanks.

kupnpdevice.cpp is weird (translate never called on the noop strings), but it turns out this code is not even compiled anymore...

- David Faure


On Aug. 9, 2012, 1:24 p.m., George Goldberg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105944/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2012, 1:24 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Description
> -------
> 
> use QCoreApplication::translate() and QT_TRANSLATE_NOOP
> 
> 
> Diffs
> -----
> 
>   tier1/solid/src/solid/backends/fstab/fstabmanager.cpp ad1ef4a39ba3c24746df7cff811257a29716cbf6 
>   tier1/solid/src/solid/backends/hal/haldevice.cpp 0fecac17158728814e17b88070f22d105ae36574 
>   tier1/solid/src/solid/backends/kupnp/internetgatewaydevice1.cpp 1d7baf4f9fd97494c598478244252142c3beec73 
>   tier1/solid/src/solid/backends/kupnp/kupnpdevice.cpp 2aa01469cf76bf458eaa830f310be6f0de642770 
>   tier1/solid/src/solid/backends/kupnp/kupnprootdevice.cpp ce4818490a8b5bce4b0af8305d551105d6eeab62 
>   tier1/solid/src/solid/backends/kupnp/mediaserver1.cpp 02d8e558ad733d599bfc0efc419ddbaeb87e3eb0 
>   tier1/solid/src/solid/backends/kupnp/mediaserver2.cpp fd91b098e4ce4657bc1e8788794636618397c717 
>   tier1/solid/src/solid/backends/kupnp/mediaserver3.cpp cd5ad312e9e0ac6c45e11fb037ade2104a5fbbfd 
>   tier1/solid/src/solid/backends/udev/udevdevice.cpp 21b97432b9bd6a93eaee2f6190cf0bf215ee6f94 
>   tier1/solid/src/solid/backends/udev/udevmanager.cpp c29f175f0a313256fda2ee8adb6895e7384574c2 
>   tier1/solid/src/solid/backends/udisks/udisksdevice.cpp 20d5654f7a0dc5c257ec7b80aa2f0db0c0315df5 
>   tier1/solid/src/solid/backends/udisks/udisksmanager.cpp 28f7bda8675e92f6cf90069b73e8e28b5c09873e 
>   tier1/solid/src/solid/backends/udisks2/udisksdevice.cpp 3076278a3eab673560cbb38019bd2d8606f57610 
>   tier1/solid/src/solid/backends/udisks2/udisksmanager.cpp 0a77c163983e1f71916993bd0c4a3db78a9c020a 
>   tier1/solid/src/solid/backends/upnp/upnpdevicemanager.cpp 985afb0d3707369f0076ea53f9418d08400badc6 
>   tier1/solid/src/solid/backends/upower/upowerdevice.cpp 39eec4f13516b6022e870b4de629c3bfc34b6607 
>   tier1/solid/src/solid/backends/upower/upowermanager.cpp c17afb946d30dea25eec90e51a9665b33e14bb81 
>   tier1/solid/src/solid/backends/wmi/wmibattery.cpp 4319ab50d3dbbe309c02691b32a69573581a78e5 
>   tier1/solid/src/solid/backends/wmi/wmidevice.cpp 157c6a96221621223e0f82191ea512e58186afdf 
>   tier1/solid/src/solid/deviceinterface.cpp 6c4d3f189936ff1bbd0b8c4ee651dd6bef8bfe4b 
> 
> Diff: http://git.reviewboard.kde.org/r/105944/diff/
> 
> 
> Testing
> -------
> 
> compiles
> 
> 
> Thanks,
> 
> George Goldberg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20120809/9a3fbf03/attachment.html>