Review Request: Port from KApplication KCmdLineArgs to QApplication in unit tests.

Stephen Kelly steveire at gmail.com
Tue Aug 7 08:20:05 UTC 2012


Jeremy Paul Whiting wrote:

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105897/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2012, 6:53 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 

I don't have a comment on the content of the patch, but when you commit, 
please do so in chunks (without a new review request for each chunk). For 
example (where each line is a commit):

kde3support: Port from KApplication KCmdLineArgs to QApplication
kdeui: Port from KApplication KCmdLineArgs to QApplication
... etc

This makes it easier to review the history (and makes git bisect more 
useful). This goes in general for all large changes that need to be done 
'accross the board' - please split them up.

Thanks for the work on this. It looks great.

Thanks,

Steve



More information about the Kde-frameworks-devel mailing list