RFC: Policy on use of *Dialog::exec() in libraries

Aaron J. Seigo aseigo at kde.org
Sun Nov 6 01:26:04 UTC 2011


On Saturday, November 5, 2011 19:20:37 David Faure wrote:
> Now the real question is how much of the existing code breaks that policy

quite a bit. a quit grep gives me 200+ hits in kdelibs right now; some are 
false positives (even though i filtered a lot out already) such as calls to 
exec() in kio slave classes (out of process, so fine) or exec() calls in 
methods that explicitly note that are synchronous (such as the file dialog 
get* methods).

so while a number of those matches will turn out to be non-issues, there are 
still probably dozens waiting for us in there.

i fixed two of them in the last few days, and they aren't that difficult.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20111106/318797b0/attachment.sig>


More information about the Kde-frameworks-devel mailing list