kactivities

[Aaron J. Seigo]

On Thursday, December 8, 2011 21:37:22 Alexander Neundorf wrote:
> On Monday 05 December 2011, Aaron J. Seigo wrote:
> > hi..
> > 
> > the Plasma team is working on the kactivities repository with the idea in
> > mind that it is a "frameworks 5" style project right from the start.
> > 
> > it currently contains a library (libkactivities), a runtime componen
> > (kactivitymanagerd) and some runtime data (ontologies).
> > 
> > what it currently lacks is full unit test coverage and upstreaming of
> > Find*.cmake files (it carries with it its own FindKActivities.cmake; i
> > will
> > email buildsystem about this one ..)
> 
> Two comments: a library should not install a find-module for itself, this
> doesn't make sense (like putting the remote control on the TV, or the
> treasure map inside the treasure chest), because once you found the
> find-module, the hard work is already done, the location where the package
> is has been found.

yes, i know .. the module isn't actually installed with libkactivities. it's 
just there to have something to copy to other modules that need to find it. 

> So, instead it should install a Config.cmake file, which instead of

it has one of those as well, but it looked a bit different to the one in the 
example. i've updated it so that it reflects the example. thanks :)

> Then, once it installs such a Config.cmake file, a find-module is strictly
> not necessary anymore, since cmake knows a set of directories (including
> using CMAKE_PREFIX_PATH) where to search for them.

ah! that's a nice feature. great, then that part is done for kactivities.

> Personally I still like to have a minimal find-module in that case two,
> which basically does two things:

make sense..

again, thanks :)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-frameworks-devel/attachments/20111209/0c0d8ddb/attachment.sig>