Week 2 & 3 commits

[Thomas Baumgart]

Prasun,

On Freitag, 19. Juni 2020 08:14:44 CEST Prasun Kumar wrote:

> Hi everyone,
> I have pushed the commits of my work in Week 2 and 3 of this project. The
> code now reads data from the SQLite DB and I have also added support for
> validity period checking.
> I have added comments by trying to follow the convention of the current
> code, but do let me know if I missed anything.

This looks generally OK to me. I have spotted one potential hole though: the method
AccountNumberCheck::callback() should check that at least the expected number
of arguments are in argv before processing them in readDatabase(). If for
whatever reason less than the 7 arguments are passed, readDatabase() will
access invalid memory. Besides that, I wonder what is passed as argv[0].

You should also make sure that the pointers passed by argv are not zero before
using them. They can be as a result of the data contained in the database.

See https://www.sqlite.org/c3ref/exec.html for details.

> Note: I have disabled the ctest benchmark for now as it requires some work
> which I plan to do this week.
> Please take a look at the code and if anything is out of place, please let
> me know.

Done, see above. Keep going. Did you blog about your work somewhere?

-- 

Regards

Thomas Baumgart

https://www.signal.org/       Signal, the better WhatsApp
-------------------------------------------------------------
I'm playing in a band called 999 MB.
We haven't gotten a gig yet.
-------------------------------------------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 868 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-finance-apps/attachments/20200620/f6c588b8/attachment.sig>