Week 2 & 3 commits

[ralf.habacker at freenet.de]

                       Hi Prasun,
 
you do not have any problem because you probably have a bankdata file installed in /usr/share/ktoblzcheck, which was taken instead.
 
Without that file the error happens because in check_bankData_lookup() the instance of AccountNumberCheck class is not created with the bankdata filename provided  as it is with check_testkontos().
 
It is important to use the bankdata file provided with the --file command line switch as the installed one may be outdated.
I suggest to add a filename parameter to
 
int check_bankData_lookup(const std::string &filename, unsigned long tries = 5)
{
  ...
   AccountNumberCheck checker(filename);
}
 
Regards
Ralf

-----ursprüngliche Nachricht-----
 Von:  prasun.code at gmail.com (mailto:prasun.code at gmail.com" target="_blank" rel="noopener)
 Gesendet: 04.07.2020 10:12 Uhr
 An:  kde-finance-apps at kde.org (mailto:kde-finance-apps at kde.org" target="_blank" rel="noopener)
 Betreff: Re: Week 2 & 3 commits




Running  ctest -VV  after building from the build dir returned:

6: Test command:
/home/xxx/src/prasun-ktoblzcheck-gsoc2020-build/bin/benchmark
"--file=/home2/xxx/src/prasun-ktoblzcheck-gsoc2020/src/bankdata/bankdata.de.db"
"5"

6: Test timeout computed to be: 10000000
6: Oops, no bank data file was found in directory
"/usr/share/ktoblzcheck"! The ktoblzcheck library will not work.
6: Oops, no bank data file was found in directory
"/usr/share/ktoblzcheck"! The ktoblzcheck library will not work.
6/9 Test #6: benchmark ........................***Failed    0.01 sec
test 7
    Start 7: ibanchk_de


Seems that the --file option is  not used inside the benchmark test. 
 
That's strange! Did the build create the database successfully? 
Does the database exists on the supplied path?
I ran it on my end and it runs without any errors. 
 

 

On Sat, 4 Jul 2020 at 15:22, Ralf Habacker < ralf.habacker at freenet.de (mailto:ralf.habacker at freenet.de" target="_blank" rel="noopener)> wrote:
Hi Prasun,
> I have added command-line options by using the code from ibanchk.cc.
> Kindly take a look
> and suggest any changes.
>
Running  ctest -VV  after building from the build dir returned:

6: Test command:
/home/xxx/src/prasun-ktoblzcheck-gsoc2020-build/bin/benchmark
"--file=/home2/xxx/src/prasun-ktoblzcheck-gsoc2020/src/bankdata/bankdata.de.db"
"5"

6: Test timeout computed to be: 10000000
6: Oops, no bank data file was found in directory
"/usr/share/ktoblzcheck"! The ktoblzcheck library will not work.
6: Oops, no bank data file was found in directory
"/usr/share/ktoblzcheck"! The ktoblzcheck library will not work.
6/9 Test #6: benchmark ........................***Failed    0.01 sec
test 7
    Start 7: ibanchk_de


Seems that the --file option is  not used inside the benchmark test. 

Regards

Ralf




 -----ursprüngliche Nachricht Ende-----    


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-finance-apps/attachments/20200704/05f154a8/attachment.htm>