Week 2 & 3 commits

Ralf Habacker ralf.habacker at freenet.de
Thu Jul 2 21:33:16 BST 2020


Am 19.06.20 um 08:14 schrieb Prasun Kumar:
> Hi everyone,
> I have pushed the commits of my work in Week 2 and 3 of this project.
> The code now reads data from the SQLite DB and I have also added
> support for validity period checking.
> I have added comments by trying to follow the convention of the
> current code, but do let me know if I missed anything.
>
> Note: I have disabled the ctest benchmark for now as it requires some
> work which I plan to do this week.
> Please take a look at the code and if anything is out of place, please
> let me know.
> Link to commits:
> https://sourceforge.net/u/prasun/ktoblzcheck-gsoc2020/commit_browser

src/bin/CMakeLists.txt

The ktoblzcheck and ktoblzcheck_invalid tests could be fixed by changing

   COMMAND ${TEST_WRAPPER} $<TARGET_FILE:ktoblzcheck-bin> --file=${TEST_PATH_PREFIX}${BANKDATA_FILEPATH} ...

to

  COMMAND ${TEST_WRAPPER} $<TARGET_FILE:ktoblzcheck-bin> --file=${BANKDATA_DBPATH} ...

BTW: I'm just back from vacation and was not able to inspect the patches before.

Regards
Ralf

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-finance-apps/attachments/20200702/2bceb09f/attachment.htm>


More information about the Kde-finance-apps mailing list