Review Request 130236: Make Qt4 build support working again by specifing -DBUILD_QT4=1 on cmake configure line

[Jack Ostroff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130236/#review103658
-----------------------------------------------------------



Please clarify - this makes the qt4 and qt5 versions of libalkimia co-installable.  Is that only if both are the same version, or is it also true if you compile libalkimia 5.0.0 (released) with qt4 and 6.0.0 (from git) with qt5?  KMyMoney 4.8 requires <6.0 and KMyMoney 5.0 (git head) requires >=6.0.  The latest change goes to 7.0.0 (was there ever a 6.0.0?) which cannot be used by KMM 4.8.x although it is still mentioned.

- Jack Ostroff


On Aug. 29, 2017, 2:06 p.m., Ralf Habacker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130236/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2017, 2:06 p.m.)
> 
> 
> Review request for KMymoney and Skrooge.
> 
> 
> Repository: alkimia
> 
> 
> Description
> -------
> 
> The installed package is coinstallable with the Qt5 variant.
> See README.md for more details how to use.
> 
> Required for building stable kmymoney releases, which are Qt4 based.
> 
> REVIEW:130236
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 19f3e4d367324841e12b426ae9cadc127aa0e597 
>   README.md PRE-CREATION 
>   autotests/CMakeLists.txt faa9973d750503cb5ef017c70a0b4a29181ab5dd 
>   src/CMakeLists.txt 9765cf7c43e5c09fe20c7a6ac1b872718eeac781 
>   src/LibAlkimiaConfig.cmake.in cce2f7c420109d981f21866b0ed57bdf7ae834f8 
>   src/libalkimia.pc.in 871e3f30ac0ead437b84707506d3b8d770d9f007 
> 
> Diff: https://git.reviewboard.kde.org/r/130236/diff/
> 
> 
> Testing
> -------
> 
> - compiled for qt4 and qt5
> - used to build with kmymoney4 and kmymoney/KF5
> - installation gives install tree for qt4: 
> tmp/usr/local/include/alkimia/Qt4/alkimia/alkcompany.h
> tmp/usr/local/include/alkimia/Qt4/alkimia/alkvalue.h
> tmp/usr/local/include/alkimia/Qt4/alkimia/alk_export.h
> tmp/usr/local/include/alkimia/Qt4/alkimia/alkquoteitem.h
> tmp/usr/local/lib64/libalkimia.so
> tmp/usr/local/lib64/libalkimia.so.7
> tmp/usr/local/lib64/libalkimia.so.7.0.90
> tmp/usr/local/lib64/pkgconfig/libalkimia.pc
> tmp/usr/local/lib64/cmake/LibAlkimia-7.0
> tmp/usr/local/lib64/cmake/LibAlkimia-7.0/LibAlkimiaConfig.cmake
> tmp/usr/local/lib64/cmake/LibAlkimia-7.0/LibAlkimiaTargets-noconfig.cmake
> tmp/usr/local/lib64/cmake/LibAlkimia-7.0/LibAlkimiaConfigVersion.cmake
> tmp/usr/local/lib64/cmake/LibAlkimia-7.0/LibAlkimiaTargets.cmake
> tmp/usr/local/lib64/cmake/LibAlkimia-7.0/FindGMP.cmake
> 
> - file content of libalkimia.pc
> 
> # pkg-config configuration for libalkimia
> # For information about the syntax, see pkg-config(1)
> 
> # General installation directories
> prefix=/usr/local
> exec_prefix=/usr/local
> libdir=
> includedir=include/alkimia/Qt4
> 
> # Human-readable name
> Name: Alkimia
> # Human-readable description
> Description: A library for financial data handling
> Version: 7.0.90
> 
> Libs: -lalkimia
> Libs.private: -lgmp -lQtCore -lQtDBus -lstdc++
> Cflags: -I${includedir}
> 
> 
> - installation gives install tree for qt5: 
> tmp/usr/local/include/alkimia/Qt5/alkimia/alkcompany.h
> tmp/usr/local/include/alkimia/Qt5/alkimia/alkvalue.h
> tmp/usr/local/include/alkimia/Qt5/alkimia/alk_export.h
> tmp/usr/local/include/alkimia/Qt5/alkimia/alkquoteitem.h
> tmp/usr/local/lib64/libalkimia5.so
> tmp/usr/local/lib64/libalkimia5.so.7
> tmp/usr/local/lib64/libalkimia5.so.7.0.90
> tmp/usr/local/lib64/pkgconfig/libalkimia5.pc
> tmp/usr/local/lib64/cmake/LibAlkimia5-7.0/LibAlkimia5Config.cmake
> tmp/usr/local/lib64/cmake/LibAlkimia5-7.0/LibAlkimia5Targets.cmake
> tmp/usr/local/lib64/cmake/LibAlkimia5-7.0/LibAlkimia5ConfigVersion.cmake
> tmp/usr/local/lib64/cmake/LibAlkimia5-7.0/LibAlkimia5Targets-noconfig.cmake
> tmp/usr/local/lib64/cmake/LibAlkimia5-7.0/FindGMP.cmake
> 
> - file content of libalkimia5.pc
> 
> # pkg-config configuration for libalkimia
> # For information about the syntax, see pkg-config(1)
> 
> # General installation directories
> prefix=/usr/local
> exec_prefix=/usr/local
> libdir=
> includedir=include/alkimia/Qt5
> 
> # Human-readable name
> Name: Alkimia
> # Human-readable description
> Description: A library for financial data handling
> Version: 7.0.90
> 
> Libs: -lalkimia5
> Libs.private: -lgmp -lQt5Core -lQt5DBus -lstdc++
> Cflags: -I${includedir}
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-finance-apps/attachments/20170829/7915a2d5/attachment-0001.html>