Review Request 130236: Make Qt4 build support working again by specifing -DBUILD_QT4=1 on cmake configure line

[Thomas Baumgart]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130236/#review103659
-----------------------------------------------------------



I have not tested it but it seems to look OK. Can someone else take a look and double-check please?


CMakeLists.txt (line 25)
<https://git.reviewboard.kde.org/r/130236/#comment68977>

    TABs?



CMakeLists.txt (line 30)
<https://git.reviewboard.kde.org/r/130236/#comment68976>

    Please name this variable CMAKE_DIR_SUFFIX.



src/LibAlkimiaConfig.cmake.in (line 8)
<https://git.reviewboard.kde.org/r/130236/#comment68975>

    Please check for TAB chars in this and the following line and replace them with blanks.


- Thomas Baumgart


On Aug. 28, 2017, 12:36 nachm., Ralf Habacker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130236/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2017, 12:36 nachm.)
> 
> 
> Review request for KMymoney and Skrooge.
> 
> 
> Repository: alkimia
> 
> 
> Description
> -------
> 
> The installed package is coinstallable with the Qt5 variant. 
> See Readme.md at https://github.com/rhabacker/alkimia for more details
> 
> Required for building stable kmymoney releases, which are Qt4 based.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 19f3e4d367324841e12b426ae9cadc127aa0e597 
>   README.md PRE-CREATION 
>   autotests/CMakeLists.txt faa9973d750503cb5ef017c70a0b4a29181ab5dd 
>   src/CMakeLists.txt 9765cf7c43e5c09fe20c7a6ac1b872718eeac781 
>   src/LibAlkimiaConfig.cmake.in cce2f7c420109d981f21866b0ed57bdf7ae834f8 
>   src/libalkimia.pc.in 871e3f30ac0ead437b84707506d3b8d770d9f007 
> 
> Diff: https://git.reviewboard.kde.org/r/130236/diff/
> 
> 
> Testing
> -------
> 
> - compiled for qt4 and qt5
> - used to build with kmymoney4 and kmymoney/KF5
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-finance-apps/attachments/20170828/db848583/attachment.html>