[Kde-finance-apps] Review Request 128364: Port bank modeller away from kcurrency/kdelibs4support

[Martin Tobias Holmedahl Sandsmark]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128364/
-----------------------------------------------------------

(Updated July 31, 2016, 4:29 p.m.)


Status
------

This change has been discarded.


Review request for Skrooge.


Repository: skrooge


Description
-------

There is no direct replacement for KCurrency available for Qt5/KF5, but it can be replaced with either using KUnitConversion (which has a hardcoded list of currency and fetches some information the European central bank, or just QLocale which uses various backends on different platforms.


Diffs
-----

  skgbankmodeler/CMakeLists.txt 90061a4 
  skgbankmodeler/skgunitobject.cpp dd3f0aa 

Diff: https://git.reviewboard.kde.org/r/128364/diff/


Testing
-------

The list of currencies are approximately the same, though it seems like KCurrency might have been a bit outdated?

There are some functional regressions, neither QLocale nor KUnitConversion provides information about when a currency was established or whether a currency is suspended or obsolete.


Thanks,

Martin Tobias Holmedahl Sandsmark

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-finance-apps/attachments/20160731/0fafd92e/attachment.html>