[Kde-finance-apps] Review Request 128365: Port away from klocale/kdelibs4support
Stephane Mankowski
stephane at mankowski.fr
Tue Jul 26 16:28:46 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128365/#review97853
-----------------------------------------------------------
I applied this path. Thanks.
- Stephane Mankowski
On July 4, 2016, 6:34 p.m., Martin Tobias Holmedahl Sandsmark wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128365/
> -----------------------------------------------------------
>
> (Updated July 4, 2016, 6:34 p.m.)
>
>
> Review request for Skrooge.
>
>
> Repository: skrooge
>
>
> Description
> -------
>
> For formatting currency and dates the change is straight forward, but QLocale does not provide information about whether the negative symbol is prefixed the currency symbol. I was however unable to find any locale supported by KLocale where this was true, so I just disabled this.
>
>
> Diffs
> -----
>
> plugins/import/skrooge_import_iif/CMakeLists.txt 66cab6e
> skgbankmodeler/skgdocumentbank.cpp 50bdd0f
> skgbasemodeler/CMakeLists.txt e2a01ac
> skgbasemodeler/skgservices.cpp cc26e73
>
> Diff: https://git.reviewboard.kde.org/r/128365/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Tobias Holmedahl Sandsmark
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-finance-apps/attachments/20160726/11f48f40/attachment.html>
More information about the Kde-finance-apps
mailing list