[Kde-finance-apps] Review Request 128364: Port bank modeller away from kcurrency/kdelibs4support

[Stephane Mankowski]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128364/#review97171
-----------------------------------------------------------



Hi,

I commited a modification in skgtestunit showing a regression due to this path.
Indeed, in getListofKnownCurrencies(bool iIncludingObsolete), the following code is not compliant with the parameter iIncludingObsolete:
static QStringList output;
    if (!output.isEmpty()) {
        return output;

Could you correct it?

Moreover, I think you can deliver a path containing only the version of code based on KUNITCONVERSION.
We don't need both options.

- Stephane Mankowski


On July 4, 2016, 10:59 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128364/
> -----------------------------------------------------------
> 
> (Updated July 4, 2016, 10:59 p.m.)
> 
> 
> Review request for Skrooge.
> 
> 
> Repository: skrooge
> 
> 
> Description
> -------
> 
> There is no direct replacement for KCurrency available for Qt5/KF5, but it can be replaced with either using KUnitConversion (which has a hardcoded list of currency and fetches some information the European central bank, or just QLocale which uses various backends on different platforms.
> 
> 
> Diffs
> -----
> 
>   skgbankmodeler/CMakeLists.txt 90061a4 
>   skgbankmodeler/skgunitobject.cpp dd3f0aa 
> 
> Diff: https://git.reviewboard.kde.org/r/128364/diff/
> 
> 
> Testing
> -------
> 
> The list of currencies are approximately the same, though it seems like KCurrency might have been a bit outdated?
> 
> There are some functional regressions, neither QLocale nor KUnitConversion provides information about when a currency was established or whether a currency is suspended or obsolete.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-finance-apps/attachments/20160706/713fb522/attachment.html>