[Kde-finance-apps] Review Request 128359: Update bundled copy of sqlite sources to fix build with Qt 5.7
Martin Tobias Holmedahl Sandsmark
martin.sandsmark at kde.org
Mon Jul 4 19:22:07 UTC 2016
> On July 4, 2016, 7:01 p.m., Stephane Mankowski wrote:
> > Hi,
> >
> > This patch builds with Qt 5.7 but not with Qt 5.5 (used on Kubuntu 16.04 for example).
> > The patch must be compliant with both version. You should be able to do that with 2 versions of private file and condition in CMakeLists.txt.
> >
> > Thank you for your contribution.
Can you test with this new version? I don't have Qt 5.5 available.
- Martin Tobias Holmedahl
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128359/#review97091
-----------------------------------------------------------
On July 4, 2016, 7:21 p.m., Martin Tobias Holmedahl Sandsmark wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128359/
> -----------------------------------------------------------
>
> (Updated July 4, 2016, 7:21 p.m.)
>
>
> Review request for Skrooge.
>
>
> Repository: skrooge
>
>
> Description
> -------
>
> Skrooge embeds some private sources of Qt, which were outdated and needed to be updated to work with Qt 5.7.
>
>
> Diffs
> -----
>
> skgsqlcipher/CMakeLists.txt 5aa096d
> skgsqlcipher/old-qsql_sqlite.cpp PRE-CREATION
> skgsqlcipher/old-qsql_sqlite_p.h PRE-CREATION
> skgsqlcipher/qsql_sqlite.cpp 7670b8e
> skgsqlcipher/qsql_sqlite_p.h f70d75f
> skgsqlcipher/skgsqlcipherdriverplugin.cpp d5c8ce2
>
> Diff: https://git.reviewboard.kde.org/r/128359/diff/
>
>
> Testing
> -------
>
> It builds and works again.
>
>
> Thanks,
>
> Martin Tobias Holmedahl Sandsmark
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-finance-apps/attachments/20160704/4daa202f/attachment.html>
More information about the Kde-finance-apps
mailing list