[Kde-finance-apps] Review Request 128361: Fix build with Qt 5.7

Stephane Mankowski stephane at mankowski.fr
Mon Jul 4 18:53:03 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128361/#review97090
-----------------------------------------------------------


Ship it!




Ship It!

- Stephane Mankowski


On July 4, 2016, 6:20 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128361/
> -----------------------------------------------------------
> 
> (Updated July 4, 2016, 6:20 p.m.)
> 
> 
> Review request for Skrooge.
> 
> 
> Repository: skrooge
> 
> 
> Description
> -------
> 
> I assume that in earlier versions of Qt qAsConst() didn't exist, that's why it was declared locally, so now don't declare it on Qt 5.7.
> 
> In addition in Qt 5.7 it is not possible to use qAsConst() with variables that are already const, so remove one usage of qAsConst where a variable was already const.
> 
> 
> Diffs
> -----
> 
>   skgbasemodeler/skgdefine.h 5c0a207 
>   skgbasemodeler/skgdocument.cpp c4b8947 
> 
> Diff: https://git.reviewboard.kde.org/r/128361/diff/
> 
> 
> Testing
> -------
> 
> It now builds with Qt 5.7.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-finance-apps/attachments/20160704/e832d50a/attachment.html>


More information about the Kde-finance-apps mailing list