[Kde-finance-apps] Review Request 124886: Improve importing csv with 2 amount colmns (credit/debit) where first one can be zero

[Rajeesh K Nambiar]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124886/
-----------------------------------------------------------

(Updated Aug. 23, 2015, 4:50 p.m.)


Review request for Skrooge.


Changes
-------

Updated tests.


Repository: skrooge


Description
-------

Some banks export transactions with Credit and Debit in separate columns with credit entry having zero debit amount and vice versa. The second amount column was always skipped as the importing code found 'zero' value and set amountSet flag on the first column.

Test case:
Sno,Account,Date,Comments,Withdrawal,Deposit
1,112233445566,24/01/2015,CASH WDL/24-01-15,6000,0
2,112233445566,29/01/2015,BIL/DEPOSIT/NSP,0,100000

Amount regex: ^withdrawal|^deposit
Sign regex: ^withdrawal

Above test case always skipped Deposit column.


Diffs (updated)
-----

  plugins/import/skrooge_import_csv/skgimportplugincsv.cpp ac93eda 
  tests/input/skgtestimportcsv/credit-debit.csv dfd4c6f 
  tests/skgbankmodelertest/skgtestimportcsv.cpp ac6e4e0 

Diff: https://git.reviewboard.kde.org/r/124886/diff/


Testing
-------

Built Fedora 22 RPM, tested importing file with multiple transactions.


Thanks,

Rajeesh K Nambiar

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-finance-apps/attachments/20150823/8940500f/attachment.html>