[Kde-finance-apps] Review Request 121030: Fixed a potential static initialization order fiasco in rr120815

[Christian David]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121030/
-----------------------------------------------------------

(Updated Nov. 7, 2014, 7:41 p.m.)


Status
------

This change has been marked as submitted.


Review request for KMymoney, Skrooge, Cristian Oneț, and Thomas Baumgart.


Repository: alkimia


Description
-------

This review request is based on 120815.

Wrapped creation of sharedZero into a static method sharedZero(). So the implicid shared object is created the first time it is used which prevents a static initialization order fiasco.


Diffs
-----

  libalkimia/alkvalue.h 7c02403adc641d1acf44c65fec39c1435e54405b 
  libalkimia/alkvalue.cpp ae5d3a4ba61c4f0100d2598660ae76c432914d90 

Diff: https://git.reviewboard.kde.org/r/121030/diff/


Testing
-------

KMyMoneys tests


Thanks,

Christian David

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-finance-apps/attachments/20141107/8b32b5e3/attachment-0001.html>