[Kde-finance-apps] Review Request 111442: Fix skroogeconvert encoding issues

Ben Cooksley bcooksley at kde.org
Sat Jul 13 23:12:28 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111442/
-----------------------------------------------------------

(Updated July 13, 2013, 11:12 p.m.)


Status
------

This change has been marked as submitted.


Review request for Skrooge.


Description
-------

Currently the framework which executes the skroogeconvert test overrides the environment variable LC_ALL, setting it to "C" while not changing the "LANG" variable. Unfortunately, when LANG is set to a value such as "en_US.UTF-8" this causes the test to fail due to encoding problems. If one of them is not set, or if they are set to compatible values, then the issue does not occur.

This patch ensures that LANG is unset prior to commencing test execution, allowing the tests affected by encoding issues to pass.


Diffs
-----

  tests/scripts/init.sh.in 34da6ee 

Diff: http://git.reviewboard.kde.org/r/111442/diff/


Testing
-------

Test previously failed on the CI system, now passes.


Thanks,

Ben Cooksley

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-finance-apps/attachments/20130713/2adebeb0/attachment.html>


More information about the Kde-finance-apps mailing list