[Kde-finance-apps] Review Request 111442: Fix skroogeconvert encoding issues

[Guillaume de Bure]

> On July 13, 2013, 2:40 p.m., Guillaume de Bure wrote:
> > Ship It!

Sorry for the long time to answer, and thanks for the fix :)


- Guillaume


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111442/#review35918
-----------------------------------------------------------


On July 8, 2013, 7:51 a.m., Ben Cooksley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111442/
> -----------------------------------------------------------
> 
> (Updated July 8, 2013, 7:51 a.m.)
> 
> 
> Review request for Skrooge.
> 
> 
> Description
> -------
> 
> Currently the framework which executes the skroogeconvert test overrides the environment variable LC_ALL, setting it to "C" while not changing the "LANG" variable. Unfortunately, when LANG is set to a value such as "en_US.UTF-8" this causes the test to fail due to encoding problems. If one of them is not set, or if they are set to compatible values, then the issue does not occur.
> 
> This patch ensures that LANG is unset prior to commencing test execution, allowing the tests affected by encoding issues to pass.
> 
> 
> Diffs
> -----
> 
>   tests/scripts/init.sh.in 34da6ee 
> 
> Diff: http://git.reviewboard.kde.org/r/111442/diff/
> 
> 
> Testing
> -------
> 
> Test previously failed on the CI system, now passes.
> 
> 
> Thanks,
> 
> Ben Cooksley
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-finance-apps/attachments/20130713/8597db0d/attachment.html>