[Kde-finance-apps] Alkimia Database Class -First Commit

[Thomas Baumgart]

Hi all,

on Monday 21 June 2010 18:53:07 Mukesh Gupta wrote:


> Hello Friends,
> 
> My first commit to  for alkimia is here
> https://svn.kde.org/home/kde/trunk/playground/office/alkimia/alkdbus/Alkrec
> ord/
> 
> It consists of alkrecord class which will handle query and register
> functions for the dbus server.Will add more functionality soon.The file
> 
> :ALK_DBASE: file is the sqlie database which is initially populated with
> 
> some records mentioned in the main.cpp file.
> For testing out the sqlite database  i use SQLite manager application which
> is a firefox addon(
> https://addons.mozilla.org/en-US/ <goog_579283277>*firefox*/addon/5817/  )
> though i have written a function to list out all database records but the
> addon provides more flexibilty.

You might want to take a look at 

http://kde-apps.org/content/show.php/sqliteman?content=53565

> Please check out the code and review .

Here's a first impression:

* please use proper indentation. Feel free to take a look at 

https://svn.kde.org/home/kde/trunk/extragear/office/kmymoney/astyle-
kmymoney.sh which will take care of the indentation for you.

* Don't use all caps for class names

* use "call by const ref" in favor of "call by value" whenever possible, e.g. 
turn

    ALKRECORD(QString Source,QString Memo,QString Amount);

into

    AlkRecord(const QString &Source, const QString &Memo,
              const QString &Amount);

* Consistency: either start variables consistently with lowercase letters

  e.g.  Duedate  -> dueDate

* use getter and setter methods instead of public accessible member variables

* provide a licence in all the source files. Please see the libalkimia source 
files as example.

* provide documentation in form of comments formatted for Doxygen processing 
(http://www.doxygen.nl)


So much for now.  I know, Rome wasn't built in one day, but I want to give as 
much feedback as possible.

-- 

Regards

Thomas Baumgart

GPG-FP: E55E D592 F45F 116B 8429   4F99 9C59 DB40 B75D D3BA
-------------------------------------------------------------
Linux, because rebooting is for adding new hardware ...
-------------------------------------------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 225 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/kde-finance-apps/attachments/20100621/ec0d45ce/attachment.sig