[Kde-extra-gear] [PATCH] cvsExtract.sh

[Klas Kalass]

Am Freitag, 13. Februar 2004 12:06 schrieb Klas Kalass:
> Am Freitag, 13. Februar 2004 11:55 schrieb Jeroen Wijnhout:
> > On Friday 13 February 2004 11:27, Klas Kalass wrote:
>
> <a lot of clearing words snipped>
>
> > > P.S: I am not that happy about the two options (admin and i18n). The
> > > tagging script should rather be completed and used to tag admin and
> > > i18n. IMHO at least i18n *should* be tagged, because you will want to
> > > change strings during development and will end up with different
> > > strings in branch and head eventually.
> >
> > i18n can still be tagged, i18nbasetag is only about the kde-i18n/subdirs
> > files. Which KEG people shouldn't tag. For example with Kile the kile.po
> > files are tagged as release_1_6_1 for example, however the
> > kde-i18n/subdirs files is not tagged by me. This would cause the script
> > to not find the kde-i18n/subdirs files, resulting in an empty list of
> > available languages. The same holds for the --noadmintag option. However,
> > I do agree, it is a bit of a hack.
>
> Ah, I see. But now I do not understand why is it an option? In what cases
> could usage of the tag on the subdirs file be wanted then? Does not look
> like like a new option, but a bugfix to me!

OK, that was a fast shoot: I realized that one might need the original 
behaviour to package applications from the base modules. I would favour
to make your new behaviour the default and provide a --is-basemodule switch or 
something similar which changes behaviour of cvsExtract.sh for extracting
apps from one of the KDE base packages. But IMHO that is not necessary.

Regards,
  Klas