D29549: Updates to SkyPoint to improve positions

[Eric Dejouhanet]

TallFurryMan added a comment.


  This is excellent. Sorry to arrive late to the party, two comments from me, one about the test mode of QtTest, and the other about build failures with versions older than Qt 5.9.

INLINE COMMENTS

> test_skypoint.cpp:32
> +{
> +    useRelativistic = Options::useRelativistic();
> +}

If you use Options, you may need to use `QStandardPaths::setTestModeEnabled` to prevent your changes from (1) depending on existing data and (2) modifying existing user data? Check the constructor of TestKSUserDB at https://github.com/KDE/kstars/blob/master/Tests/auxiliary/testksuserdb.cpp.

> test_skypoint.cpp:37
> +{
> +    Options::setUseRelativistic(useRelativistic);
> +}

This will not be executed if the test crashes, hence modifying local user data.

> test_skypoint.cpp:247
> +{
> +    QTest::addColumn<double>("Ra");
> +    QTest::addColumn<double>("Dec");

You need to #ifdef this against Qt 5.9, see the example at `TestEkosSimulator::testMountSlew_data` at https://github.com/KDE/kstars/blob/master/Tests/kstars_ui/test_ekos_simulator.cpp.

> test_skypoint.cpp:262
> +    SkyPoint sp;
> +    QFETCH(double, Ra);
> +    QFETCH(double, Dec);

You need to #ifdef this against Qt 5.9, see the example at `TestEkosSimulator::testMountSlew_data` at https://github.com/KDE/kstars/blob/master/Tests/kstars_ui/test_ekos_simulator.cpp.

> test_skypoint.cpp:293
> +    SkyPoint sp;
> +    QFETCH(double, Ra);
> +    QFETCH(double, Dec);

Qt 5.9

> test_skypoint.cpp:324
> +    SkyPoint sp;
> +    QFETCH(double, Ra);
> +    QFETCH(double, Dec);

Qt 5.9.

> test_skypoint.cpp:367
> +    SkyPoint sp;
> +    QFETCH(double, Ra);
> +    QFETCH(double, Dec);

Qt 5.9.

> test_skypoint.cpp:393
> +{
> +    QTest::addColumn<double>("Ra");
> +    QTest::addColumn<double>("Dec");

Qt 5.9.

> test_skypoint.cpp:412
> +    SkyPoint sp;
> +    QFETCH(double, Ra);
> +    QFETCH(double, Dec);

Qt 5.9.

REPOSITORY
  R321 KStars

REVISION DETAIL
  https://phabricator.kde.org/D29549

To: chrisrowland, mutlaqja, TallFurryMan
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20200511/93cdeb6f/attachment-0001.htm>