D28456: number Sequence, move config to activity config

Johnny Jazeix noreply at phabricator.kde.org
Tue Mar 31 10:38:27 BST 2020


jjazeix added inline comments.

INLINE COMMENTS

> NumberSequence.qml:278
>              id: bonus
> -            Component.onCompleted: items.mode == 1 ? win.connect(Activity.nextLevel) : win.disconnect(Activity.nextLevel)
> +            onWin: items.mode == 1 ? Activity.nextLevel() : 1;
>          }

a if() is way clearer, why using a ternary here?

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D28456

To: shubhammishra, jjazeix, #gcompris_improvements
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20200331/294a21a8/attachment-0001.html>


More information about the kde-edu mailing list