D28292: Added tests for the Focus module.

[Eric Dejouhanet]

TallFurryMan created this revision.
TallFurryMan added a reviewer: KStars.
Herald added a project: KDE Edu.
Herald added a subscriber: kde-edu.
TallFurryMan requested review of this revision.

REVISION SUMMARY
  This is a WIP on tests for the Focus module.
  We see that:
  
  - There is no way to determine when the star detection procedure is done. The capture button should re-enable when everything is finished.
  - The CCD Simulator needs improvement for some detection mechanisms to work properly.
  - It is difficult to create fixtures with deterministic verifications, although better controlling the simulation time should help.
  - Syncing the mount to object coordinates is a good idea to speed up tests.
  - When not tracking, the CCD Simulator doesn't render trails, it could be a nice improvement.
  - Because kstars_ui_tests is becoming larger, it needs to be divided into multiple smaller tests for efficiency.
  - QTest, because failing a test means returning from the test function, is macro hell.
  - QComboBox is difficult to control programmatically because of its internal signal management.

TEST PLAN
  Run kstars_ui_tests.

REPOSITORY
  R321 KStars

BRANCH
  improve__concurrent_star_detector (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28292

AFFECTED FILES
  Tests/kstars_ui/CMakeLists.txt
  Tests/kstars_ui/kstars_ui_tests.cpp
  Tests/kstars_ui/test_ekos_focus.cpp
  Tests/kstars_ui/test_ekos_focus.h
  Tests/kstars_ui/test_ekos_simulator.h

To: TallFurryMan, #kstars
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20200325/0c82a91d/attachment.html>