D28207: Add unit test for Scilab backend

[Alexander Semke]

asemke added inline comments.

INLINE COMMENTS

> testscilab.cpp:24
> +#include "result.h"
> +#include "scilabexpression.h"
> +#include "session.h"

where do you need this header file?

> testscilab.cpp:28
> +
> +#include <QDebug>
> +

shouldn't be required here.

> testscilab.cpp:39
> +
> +    QVERIFY( e!=nullptr );
> +    QVERIFY( e->result()!=nullptr );

the usage of spaces is not consistent in Cantor's code. For new code we try to be more consistent and use spaces around operators. We don't use spaces next to the bracket. So, it should be

  QVERIFY(e != nullptr);

REPOSITORY
  R55 Cantor

REVISION DETAIL
  https://phabricator.kde.org/D28207

To: shubham, asemke
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20200322/f0a107af/attachment.html>