D27583: rebuild mosaic multiple dataset

Deepak Kumar noreply at phabricator.kde.org
Tue Mar 10 07:50:14 GMT 2020


dekumar added inline comments.

INLINE COMMENTS

> jjazeix wrote in Data.qml:33
> The issue is about data1, data2. What does it mean? Put yourself in the place of someone that does not know the code, starts to read it and see: we are using "data1". How do you interpret that?

Sure, I would rename it.

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D27583

To: dekumar, #gcompris_improvements, jjazeix, timotheegiet, echarruau
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20200310/143e48e8/attachment.html>


More information about the kde-edu mailing list