D29840: enumeration memory games multiple_dataset

Johnny Jazeix noreply at phabricator.kde.org
Tue Jun 2 08:40:35 BST 2020


jjazeix added inline comments.

INLINE COMMENTS

> Data.qml:29
> +
> +    property var url: "qrc:/gcompris/src/activities/memory-enumerate/resource/"
> +

string

> MemoryCommon.qml:70
>              property int playerScore: playerScore.text
> -            property var dataset: activity.dataset
> +            property var levels: activity.datasetLoader.data !=  0 ? activity.datasetLoader.data : activity.dataset
>              property alias containerModel: containerModel

is there a reason to check a dataset against 0?

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D29840

To: dekumar, #gcompris_improvements, jjazeix, timotheegiet, AkshayCHD, amankumargupta, echarruau
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20200602/9507b975/attachment.htm>


More information about the kde-edu mailing list