D26637: balance scales multiple dataset

[Johnny Jazeix]

jjazeix added a comment.


  Except a small fix, it seems good to me on code side, but I haven't tested it yet

INLINE COMMENTS

> scalesboard.js:81
> +function checkAnswer() {
> +    if((initCompleted && items.scaleHeight == 0 && items.question.hasText == "")
> +            || (items.question.userEntry == items.question.answer)) {

items.question.hasText is a boolean, it would be better to check with true or false

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D26637

To: dekumar, #gcompris_improvements, jjazeix, echarruau, timotheegiet
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20200121/a4dfb442/attachment.html>