D26384: Refactor polynomial code in focus and other small changes

[Hy Murveit]

murveit created this revision.
murveit added reviewers: mutlaqja, lancaster.
Herald added a project: KDE Edu.
Herald added a subscriber: kde-edu.
murveit requested review of this revision.

REVISION SUMMARY
  Refactor the polynomial code so it can be shared between the polynomial focus algorithm and the linear focus algorithm.
  The Linear Focus Algorithm now plots a polynomial fit to its data, though it doesn't use that polynomial (yet).
  The plan is to add the use of the polynomial in a future change to the linear focus algorithm.
  Changed the name of a FocusParams field to make it more sensible--it currentPosition becomes startPosition.
  Fixed a small bug where the red indices printed on the circles in the focus plot were lost when panning/zooming.

TEST PLAN
  The refactor and name change shouldn't affect performance, so to test that, see that polynomial and linear focus still solve focus using the simulator with reasonable parameters.
  See that the linear focus module now plots a polynomial graph when it gets a polynomial fit.
  Note that the bug, where the numbers on the focus sample points disappeared when zooming & panning, no longer happens.

REPOSITORY
  R321 KStars

BRANCH
  refactor-focus-polynomial (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26384

AFFECTED FILES
  kstars/CMakeLists.txt
  kstars/ekos/focus/focus.cpp
  kstars/ekos/focus/focus.h
  kstars/ekos/focus/focusalgorithms.cpp
  kstars/ekos/focus/focusalgorithms.h
  kstars/ekos/focus/polynomialfit.cpp
  kstars/ekos/focus/polynomialfit.h

To: murveit, mutlaqja, lancaster
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20200103/32aebe8a/attachment.html>