D27728: Multiple dataset to chronos

[Johnny Jazeix]

jjazeix added a comment.


  Please add reviewers too

INLINE COMMENTS

> Babymatch.qml:35
>      property string soundsUrl: boardsUrl
> +    property string activityName: "babymatch"
>      property string boardsUrl: "qrc:/gcompris/src/activities/babymatch/resource/"

A generic property should be used instead of having a specific one for each activity.
Babymatch is derived in a lot of activities and if every time we add a dataset for one activity, we need to both add a activityName + find in the code the specific place to add this if, it won't be maintainable.
Having a boolean "useMultipleDataset" would be better.

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D27728

To: shubhammishra
Cc: jjazeix, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20200229/7e51a573/attachment.html>