D27678: Restructure tests, add simulator tests, spot expected failures.

Yuri Chornoivan noreply at phabricator.kde.org
Wed Feb 26 19:35:26 GMT 2020


yurchor added a comment.


  Thanks in advance for fixing minor issues.

INLINE COMMENTS

> test_ekos.h:1
> +#ifndef TEST_EKOS_H
> +#define TEST_EKOS_H

Is it possible to add copyright statement?

> test_ekos.h:52
> +#endif
> +#endif // TEST_EKOS_H

Missing newline at the end.

> test_ekos_simulator.cpp:2
> +/*  KStars UI tests
> +    Copyright (C) 218, 2020
> +    Csaba Kertesz <csaba.kertesz at gmail.com>

2018?

> test_ekos_simulator.cpp:153
> +
> +#endif

Missing newline at the end.

> test_ekos_simulator.h:1
> +#ifndef TESTEKOSSIMULATOR_H
> +#define TESTEKOSSIMULATOR_H

Is it possible to add copyright statement?

> test_ekos_simulator.h:55
> +#endif
> +#endif // TESTEKOSSIMULATOR_H

Missing newline at the end.

REPOSITORY
  R321 KStars

REVISION DETAIL
  https://phabricator.kde.org/D27678

To: TallFurryMan, #kstars, mutlaqja
Cc: yurchor, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20200226/2a6ec36e/attachment.html>


More information about the kde-edu mailing list