D27437: Add logging to help debug some capture stalls

Hy Murveit noreply at phabricator.kde.org
Sun Feb 16 20:04:57 GMT 2020


murveit added a comment.


  Jasem, I understand you sentiments, but in this case I respectfully disagree.
  Here, the first 3 debug log statements will add at most one line per initiation of autofocus, and most likely nothing at all.
  That's 0-10 or 20 lines in logs that can be > 100K lines. The final log statement would add one one line per capture. 
  While that could be a hundred lines per log, again, a tiny percentage, and could help us debug a hard-to-find bug.
  
  How about this: any time someone adds a log statement, they should estimate the number of lines added.
  Perhaps we should also schedule removal of such lines.
  
  Also, it would make sense to go over the current logging and decide which statements are no longer necessary.
  I think that makes more sense than adding another debugging layer.
  
  In any case, I'd recommend that we add the statements in this PR in hopes that they help us find the current issues, 
  and then discuss in a month or two whether to remove them.

REPOSITORY
  R321 KStars

REVISION DETAIL
  https://phabricator.kde.org/D27437

To: murveit, mutlaqja
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20200216/86a1c401/attachment.html>


More information about the kde-edu mailing list