D26637: balance scales multiple dataset

[Johnny Jazeix]

jjazeix added inline comments.

INLINE COMMENTS

> Question.qml:41
>          radius: 8
> -        opacity: question.displayed ? 1 : 0
> +        opacity: question.visible ? 1 : 0
>  

you don't need to set the opacity to 0 if it is not visible

> Question.qml:60
>          wrapMode: TextEdit.WordWrap
> -        opacity: question.displayed ? 1 : 0
> +        opacity: question.visible ? true : false
>          text: question.text != "" ? question.text.arg(question.userEntry) : ""

same as above + opacity is a real between 0.0 and 1.0, not a boolean

> Scalesboard.qml:277
> +            anchors.leftMargin: parent.width * 0.01
> +            visible: (!question.text ||  items.question.userEntry) ? true : false
> +            ParticleSystemStarLoader {

remove extra space

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D26637

To: dekumar, #gcompris_improvements, jjazeix, echarruau, timotheegiet
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20200212/b6aef11c/attachment-0001.html>