D26637: balance scales multiple dataset

Johnny Jazeix noreply at phabricator.kde.org
Mon Feb 3 19:53:32 GMT 2020


jjazeix added a comment.


  Can you please add validation upon "Enter"/"Return" key press?
  Code and test is good for now :)

INLINE COMMENTS

> Data.qml:24
> +Dataset {
> +    objective: qsTr("Balance the scales until 5grams.")
> +    difficulty: 2

missing space

> Data.qml:50
> +            "message": qsTr("Now you have to guess the weight of the gift."),
> +            "question": qsTr("Enter the weight of the gift: %1")
> +        }

For activities that have units, it would be better to add which unit is expected in the question (for example, when we have both kg and g, it is not obvious that we expect an answer in grams)

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D26637

To: dekumar, #gcompris_improvements, jjazeix, echarruau, timotheegiet
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20200203/06ee05a2/attachment.html>


More information about the kde-edu mailing list