D26712: Multiple Dataset for enumerate
    Johnny Jazeix 
    noreply at phabricator.kde.org
       
    Mon Feb  3 19:35:15 GMT 2020
    
    
  
jjazeix added inline comments.
INLINE COMMENTS
> enumerate.js:111
>          if(userAnswers[key] !== answerToFind[key]) {
> -            return;
> -        }
> +            items.answerColumn.itemAt(i).color = "red";
> +            isAnswerGood = false;
instead of changing the color directly, can you use a state in the AnswerArea and handle the different colors directly in it?
> enumerate.js:113
> +            isAnswerGood = false;
> +        }else
> +            items.answerColumn.itemAt(i).color = "green";
put the else on the other line
> enumerate.js:174
> +    for (var key in answerToFind) {
> +        if(typeof userAnswers[key] == 'undefined' )
> +            return
remove space before )
REPOSITORY
  R2 GCompris
REVISION DETAIL
  https://phabricator.kde.org/D26712
To: shubhammishra, #gcompris_improvements, jjazeix, echarruau
Cc: johnny, kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20200203/0f61e33b/attachment.html>
    
    
More information about the kde-edu
mailing list