D29218: Fix bug where tab fitsviews weren't receiving images when fitsviewer was not enabled

[Hy Murveit]

murveit created this revision.
murveit added a reviewer: mutlaqja.
Herald added a project: KDE Edu.
Herald added a subscriber: kde-edu.
murveit requested review of this revision.

REVISION SUMMARY
  The bug is described in https://indilib.org/forum/ekos/6756-re-problems-with-focus-module-images-not-coming-in.html?start=36#52722
  though I actually don't think the particular technique to trigger autofocus matters.
  What matters is that fitsviewer is not enabled in the KSTARS FITS settings (not mentioned in that particular thread post).
  There was a test for not displaying if fitsviewer was not enabled, but it should have added "but only for NORMAL or CALIBRATION images"
  as the other kinds of images have their own private fitsview. There is further complication with batch mode.

TEST PLAN
  Repeat procedure described in the above forum thread and importantly also disable fitsviewer in the KSTARS FITS options.
  Without this fix, the manual focus procedure works, but the automated (after 1 minute) autofocus should get the same 
  number of stars and HFR calculation for each input image. With this fix, the #stars and HFRs should vary as normal.

REPOSITORY
  R321 KStars

BRANCH
  fix-no-fitsviewer-bug (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29218

AFFECTED FILES
  kstars/indi/indiccd.cpp

To: murveit, mutlaqja
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20200426/2dba5c30/attachment.html>