D29099: Make the Focus capture action include star detection

[Eric Dejouhanet]

TallFurryMan created this revision.
TallFurryMan added a reviewer: KStars.
Herald added a project: KDE Edu.
Herald added a subscriber: kde-edu.
TallFurryMan requested review of this revision.

REVISION SUMMARY
  This differential makes the Focus capture button state reflect exposure and detection.
  Before that change, the capture button reverted to the enable state after the frame was received but the source extraction continued in the background.
  The UI was therefore ready to accept user input, but at the same time unresponsive.
  The differential adjusts the UI tests to wait for the capture button to re-enable, instead of inserting a suitable delay before waiting.
  
  This differential also replaces an assertion generated when the tracking box is enabled in full-field detection, with an immediate disable of the tracking box.
  This differential also rewrites the tooltip displayed by the detection method drop-down, providing more detailed information.
  This differential also fixes the explicit assignment operator warnings.

TEST PLAN
  UI tests through kstars_ui_tests. Jenkins builds for warnings.

REPOSITORY
  R321 KStars

BRANCH
  improve__determine_star_detection_end (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29099

AFFECTED FILES
  Tests/kstars_ui/test_ekos_focus.cpp
  Tests/kstars_ui/test_ekos_focus.h
  kstars/ekos/focus/focus.cpp
  kstars/ekos/focus/focus.ui
  kstars/fitsviewer/fpackutil.c
  kstars/printing/legend.cpp
  kstars/printing/legend.h
  kstars/time/kstarsdatetime.cpp
  kstars/time/kstarsdatetime.h
  kstars/tools/modcalcvizequinox.cpp

To: TallFurryMan, #kstars
Cc: kde-edu, narvaez, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-edu/attachments/20200422/077e7e6c/attachment.html>